Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regular updates (Apr 21) #1174

Merged
merged 9 commits into from
Apr 27, 2020
Merged

Regular updates (Apr 21) #1174

merged 9 commits into from
Apr 27, 2020

Conversation

jorgeorpinel
Copy link
Contributor

@jorgeorpinel jorgeorpinel commented Apr 21, 2020 •
edited
Loading

  • Import dvc lock cmd ref about unlocking or updating import stages.
  • dvc list and dvc root cmd refs rewrite
  • Other misc. stuff

@shcheklein shcheklein temporarily deployed to dvc-landing-2020-04-21-ourebfm April 21, 2020 08:13 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-2020-04-21-ourebfm April 22, 2020 02:20 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-2020-04-21-ourebfm April 22, 2020 02:23 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-2020-04-21-ourebfm April 22, 2020 02:24 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-2020-04-21-ourebfm April 23, 2020 03:01 Inactive
@jorgeorpinel jorgeorpinel marked this pull request as ready for review April 23, 2020 17:22
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-2020-04-21-ourebfm April 23, 2020 17:22 Inactive
@jorgeorpinel jorgeorpinel changed the title [WIP] Regular updates (Apr 21) Regular updates (Apr 21) Apr 23, 2020
@jorgeorpinel jorgeorpinel mentioned this pull request Apr 23, 2020
Closed
shcheklein
shcheklein requested changes Apr 25, 2020
View reviewed changes
Copy link
Member

@shcheklein shcheklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few comments here and there. Looks good overall!

@weekly-digest weekly-digest bot mentioned this pull request Apr 26, 2020
Closed
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-2020-04-21-ourebfm April 26, 2020 18:41 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-2020-04-21-ourebfm April 27, 2020 02:55 Inactive
@jorgeorpinel jorgeorpinel requested a review from shcheklein April 27, 2020 05:03
shcheklein
shcheklein approved these changes Apr 27, 2020
View reviewed changes
Copy link
Member

@shcheklein shcheklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! One minor comment - probably missed some markup there?

@jorgeorpinel jorgeorpinel merged commit d10763c into master Apr 27, 2020
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-2020-04-21-ourebfm April 27, 2020 19:28 Inactive
@weekly-digest weekly-digest bot mentioned this pull request May 3, 2020
Closed
@jorgeorpinel jorgeorpinel deleted the 2020-04-21 branch May 5, 2020 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shcheklein shcheklein shcheklein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jorgeorpinel @shcheklein